Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: move to vendoring go dependencies #3522

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

bazel: move to vendoring go dependencies #3522

wants to merge 1 commit into from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Jul 11, 2024

What this PR does / why we need it:

Replaces the bazel dependency management for go repositories with pure go mod vendoring.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @brianmcarey

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jul 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/cc @xpivarc

FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only.

@dhiller dhiller marked this pull request as draft July 11, 2024 12:16
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@dhiller dhiller force-pushed the replace-bazel-go-repo-deps-with-vendoring branch from fe2cbe6 to 343c83c Compare July 11, 2024 12:34
@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/test pull-project-infra-test-robots

@dhiller dhiller force-pushed the replace-bazel-go-repo-deps-with-vendoring branch from 343c83c to 588fdee Compare July 11, 2024 12:37
@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/rehearse ?

@kubevirt-bot
Copy link
Contributor

Rehearsal is available for the following jobs in this PR:

pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/rehearse pull-project-infra-test-robots

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/test pull-project-infra-test-robots

@xpivarc
Copy link
Member

xpivarc commented Jul 11, 2024

/cc @xpivarc

FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only.

I like vendoring 👍

@dhiller dhiller force-pushed the replace-bazel-go-repo-deps-with-vendoring branch from 588fdee to 5e7a333 Compare July 11, 2024 13:35
@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/rehearse pull-project-infra-test-robots

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/test pull-project-infra-test-robots

@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/test pull-project-infra-test-bazel-config

@dhiller dhiller force-pushed the replace-bazel-go-repo-deps-with-vendoring branch from 5e7a333 to fe2e392 Compare July 11, 2024 14:09
@dhiller
Copy link
Contributor Author

dhiller commented Jul 11, 2024

/rehearse pull-project-infra-test-bazel-config

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@dhiller
Copy link
Contributor Author

dhiller commented Jul 12, 2024

/test all

@dhiller dhiller force-pushed the replace-bazel-go-repo-deps-with-vendoring branch from fe2e392 to e1c0f98 Compare July 12, 2024 14:32
@dhiller
Copy link
Contributor Author

dhiller commented Jul 12, 2024

/test all

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@dhiller
bazel: move to vendoring go dependencies
e65e1a2 
Remove gazelle-update-repos make target as no longer required on the
way.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller dhiller force-pushed the replace-bazel-go-repo-deps-with-vendoring branch from e1c0f98 to e65e1a2 Compare July 25, 2024 08:10
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Jul 25, 2024

/test all

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jul 25, 2024 •
edited
Loading

@dhiller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-project-infra-test-robots 588fdee link unknown /test pull-project-infra-test-robots
pull-project-infra-ci-search-deploy-test e65e1a2 link true /test pull-project-infra-ci-search-deploy-test
pull-project-infra-test-bazel-config e65e1a2 link true /test pull-project-infra-test-bazel-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 4, 2024

/remove-lifecycle stale

@xpivarc this is the effort to move towards vendoring, which I talked about in today's sig-ci meeting

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2024
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

@xpivarc xpivarc Awaiting requested review from xpivarc

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiller @kubevirt-bot @xpivarc